Conversation
khalford
reviewed
Jan 15, 2026
c8686ad to
64c88f9
Compare
khalford
previously approved these changes
Jan 15, 2026
Collaborator
Author
|
Ah you've beat me to it as my push was rejected, could you include the comment so we don't revert this later on |
Member
Sorry, yes I've put it back in. |
Collaborator
Author
|
We'll need to also re-test RL and Ubuntu still boot with this in BIOS mode, as I'm not sure if the base |
Collaborator
Author
|
LGTM |
khalford
previously approved these changes
Jan 15, 2026
We need to force BIOS until we're running EFI and above 4GB decoding everywhere. The kernel and Nvidia drivers will try to use reallocatable BARs from the EFI, but there are none on our existing RL8 hosts because they're running BIOS's with above 4GB decoding disabled. There's a slightl perf degredation on the GPUs and booting (but not a regression as we're already BIOS booting for these images) by using BIOS instead of EFI. But until we get all our hosts to RL9+ with EFI enabled we'll have to save this small perf improvement for the future when we can switch on later.
khalford
approved these changes
Jan 15, 2026
azahmd
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to force BIOS until we're running EFI and above 4GB decoding everywhere. The kernel and Nvidia drivers will try to use reallocatable BARs from the EFI, but there are none on our existing RL8 hosts because they're running BIOS's with above 4GB decoding disabled.
There's a slightl perf degredation on the GPUs and booting (but not a regression as we're already BIOS booting for these images) by using BIOS instead of EFI. But until we get all our hosts to RL9+ with EFI enabled we'll have to save this small perf improvement for the future when we can switch on later.